Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security): bump node-ip dependency #591

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

gastonfournier
Copy link
Contributor

About the changes

Fix a security vulnerability reported in node-ip package. This vulnerability is not affecting us because the method at stake is not used in the SDK.

Closes #586

@coveralls
Copy link

Coverage Status

coverage: 90.863%. remained the same
when pulling e446638 on security/5.5-patch
into 383c06e on main.

@gastonfournier gastonfournier self-assigned this Feb 19, 2024
@gastonfournier gastonfournier merged commit c70d918 into main Feb 19, 2024
5 checks passed
@gastonfournier gastonfournier deleted the security/5.5-patch branch February 19, 2024 09:45
renovate bot referenced this pull request in Unleash/unleash Mar 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [unleash-client](https://togithub.com/Unleash/unleash-client-node) |
[`5.5.0` ->
`5.5.1`](https://renovatebot.com/diffs/npm/unleash-client/5.5.0/5.5.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/unleash-client/5.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/unleash-client/5.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/unleash-client/5.5.0/5.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/unleash-client/5.5.0/5.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Unleash/unleash-client-node (unleash-client)</summary>

###
[`v5.5.1`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v5.5.1)

[Compare
Source](https://togithub.com/Unleash/unleash-client-node/compare/v5.5.0...v5.5.1)

#### What's Changed

- chore(deps): update unleash/.github action to v1.1.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Unleash/unleash-client-node/pull/584](https://togithub.com/Unleash/unleash-client-node/pull/584)
- chore(deps): update dependency prettier to v3.2.5 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Unleash/unleash-client-node/pull/576](https://togithub.com/Unleash/unleash-client-node/pull/576)
- chore(deps): update dependency redis to v4.6.13 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Unleash/unleash-client-node/pull/577](https://togithub.com/Unleash/unleash-client-node/pull/577)
- chore(deps): update dependency semver to v7.6.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/Unleash/unleash-client-node/pull/578](https://togithub.com/Unleash/unleash-client-node/pull/578)
- chore(security): bump node-ip dependency by
[@&#8203;gastonfournier](https://togithub.com/gastonfournier) in
[https://github.com/Unleash/unleash-client-node/pull/591](https://togithub.com/Unleash/unleash-client-node/pull/591)

**Full Changelog**:
Unleash/unleash-client-node@v5.5.0...v5.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am
every weekday" in timezone Europe/Madrid, Automerge - At any time (no
schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@glensc
Copy link

glensc commented Mar 11, 2024

note: this doesn't actually remove the vulnerable version (2.0.0) from lock file:

you could use yarn deduplicate to merge those dependencies:

or just edit the lock file manually.

@gastonfournier
Copy link
Contributor Author

Thanks @glensc for pointing this out! I think #601 should solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace vulnerable ip dependency
4 participants